Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Assist PR] Update stored data #12

Merged
merged 1 commit into from
Mar 1, 2024
Merged

[Assist PR] Update stored data #12

merged 1 commit into from
Mar 1, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Mar 1, 2024

Update stored data.
Auto-generated.

@hugobuddel
Copy link
Contributor

We disabled the caching of the parameters in AstarVienna/skycalc_ipy#30, that's why there is not .params.json associated with the cached FITS file.

@teutoburg do you still think that the parameters should not be cached? If so, then we should probably remove the other *.params.json files from this repository too.

I already miss the parameters file, because I have no idea where this new FITS file came from, and the parameters file might make it easier to figure that out. Maybe a traceback file would be even more useful 😃

@teutoburg
Copy link
Contributor

I already miss the parameters file, because I have no idea where this new FITS file came from, and the parameters file might make it easier to figure that out. Maybe a traceback file would be even more useful 😃

The input parameters are stored in the FITS header, so it should be trivial to just read them from there, which in my opinion makes the parameter file redundant anyway. But we could add a debug level logging call with the parameters and enable logging to file here in this repo. The latter might be useful generally.

If so, then we should probably remove the other *.params.json files from this repository too.

Let's get rid of them 🙂

@hugobuddel hugobuddel merged commit 2a2406c into main Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants