Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytest --doctest-modules #105

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix pytest --doctest-modules #105

merged 1 commit into from
Oct 29, 2024

Conversation

hugobuddel
Copy link
Collaborator

No description provided.

@hugobuddel hugobuddel requested a review from teutoburg October 28, 2024 20:06
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.46%. Comparing base (c357742) to head (086a098).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
scopesim_templates/misc/misc.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   73.48%   73.46%   -0.02%     
==========================================
  Files          30       30              
  Lines        1482     1485       +3     
==========================================
+ Hits         1089     1091       +2     
- Misses        393      394       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly useful to have our docstrings pass doctest. It's something I wanted to look into at some point, but was never a priority.

@hugobuddel
Copy link
Collaborator Author

It wasn't really a priority now either, but I ran into the problem that I wanted to add a test in #104 by copying the docstring, and then the docstring didn't actually run. So I thought, let's just fix that. And then it took 2 hours or so.....

@hugobuddel hugobuddel merged commit 55455de into main Oct 29, 2024
13 of 19 checks passed
@hugobuddel hugobuddel deleted the hb/fixdocstrings branch October 29, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants