Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass kwargs from star_field() to stars() #112

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Pass kwargs from star_field() to stars() #112

merged 3 commits into from
Nov 26, 2024

Conversation

teutoburg
Copy link
Contributor

This allows to pass e.g. library="kurucz" to get spectra that actually cover the wavelength range of METIS 🙄

@teutoburg teutoburg self-assigned this Nov 26, 2024
@teutoburg teutoburg added the bug Something isn't working label Nov 26, 2024
@teutoburg teutoburg marked this pull request as ready for review November 26, 2024 17:47
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.27%. Comparing base (2dfb7cd) to head (58ef400).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   74.27%   74.27%           
=======================================
  Files          30       30           
  Lines        1485     1485           
=======================================
  Hits         1103     1103           
  Misses        382      382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@teutoburg teutoburg merged commit c59a987 into main Nov 26, 2024
20 checks passed
@teutoburg teutoburg deleted the fh/quarks branch November 26, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants