Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the Actions configuration and added Loader to yaml.load #4

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Updated the Actions configuration and added Loader to yaml.load #4

merged 2 commits into from
Oct 21, 2021

Conversation

tomasstolker
Copy link
Contributor

Hello @AstarVienna,

Thanks for providing this helpful Python wrapper for SkyCalc!

This PR updates two minor things:

  • Added pip install . in the workflow configuration which I think may solve the error with the Actions
  • In got a deprecation warning regarding the use of yaml.load without Loader so I have added the parameter

astronomyk
astronomyk approved these changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@astronomyk astronomyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this!

@tomasstolker
Copy link
Contributor Author

Locally it was running fine but an error occurred with the Github workflow. Maybe it is solved when the import that I have added now but not sure.

@astronomyk astronomyk merged commit e8eead1 into AstarVienna:master Oct 21, 2021
@tomasstolker tomasstolker deleted the actions_yaml branch October 21, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astronomyk astronomyk astronomyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasstolker @astronomyk