Use sphinx-book-theme #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teutoburg
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 75.40% 75.40%
=======================================
Files 3 3
Lines 366 366
=======================================
Hits 276 276
Misses 90 90 ☔ View full report in Codecov by Sentry. |
hugobuddel
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
This moves us dangerously close from developer wanking to bike shedding, so I'm not even going to look-up the differences between the themes and potentially find something to argue about. Approved! 🚲 🖌️
To be more constructive: I don't believe we put in too much effort in selecting the theme. Some projects had alabaster, which I recall looked horrible, so we switched those to sphinx_rtd_theme, IIRC. If sphinx_book_theme is even better, then that's fine with me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks nicer in my opinion, but this might be biased by personal taste ...
It has a lot more options to configure, but playing with that only makes sense if we decide to use it at all.