Relax httpx dependency from ^0.23.0 to >=0.23.0 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The carret prevents any newer 'minor' releases of httpx to be used, because the 'major' version is 0. This makes it difficult to upgrade other dependencies of ScopeSim like notebook, because those depend on newer versions of httpx. It is probably fine to just use >= for httpx, as we only use basic features that will probably not be deprecated or break.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 75.60% 75.60%
=======================================
Files 3 3
Lines 369 369
=======================================
Hits 279 279
Misses 90 90 ☔ View full report in Codecov by Sentry. |
teutoburg
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The carret prevents any newer 'minor' releases of httpx to be used, because the 'major' version is 0. This makes it difficult to upgrade other dependencies of ScopeSim like notebook, because those depend on newer versions of httpx.
It is probably fine to just use >= for httpx, as we only use basic features that will probably not be deprecated or break.