Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android 13 & Various Improvements #190

Merged
merged 44 commits into from
Feb 17, 2023
Merged

Android 13 & Various Improvements #190

merged 44 commits into from
Feb 17, 2023

Conversation

Doomsdayrs
Copy link
Contributor

To quiet down the android inspector

@Doomsdayrs
Remove redundant target API notices
a190879 
We have long past those versions.
@Doomsdayrs
Inline old sdk checks
46c7680
@Doomsdayrs
Update copyright
afd054a 
There are dubious copyright due to using MIT licensed code. If we rewrite the code it should be fine.
@Doomsdayrs
Add NEARBY_WIFI_DEVICES permission
a610764 
A theoretical fix
@Doomsdayrs
Remove redundant suppression in ScreenshotService
ac886d0
@Doomsdayrs
Localize variables
f949e88
@Doomsdayrs
Make value final in NotificationPreferences
8428b6b
@Doomsdayrs
Use Main looper in MainActivity.SynchronizationHandler
d8b2f23
@Doomsdayrs
Update method of name retrieval in NotificationParser
ddbf9e9
@Doomsdayrs
Use default super constructor in PhoneStateReceiver
3d665b4
@Doomsdayrs
Use main looper for SynchronizationService.SynchronizationHandler
6cb5321
@Doomsdayrs
Replace setBuiltInZoomControls with direct call in WeatherSettingsFrag
ba6ccc4
@Doomsdayrs
Replace C Style array declaration in WeatherSettingsFragment
26adbf0
@Doomsdayrs
Make various non-final variables final due to never being modified
09b6aef
@Doomsdayrs
Remove unnecessary toString calls
e6f8ad2
@Doomsdayrs
Remove redundant public declaration in interface
2ef943e
@Doomsdayrs
Simplify if statement in AppInfoHelper
19a8e9a
@Doomsdayrs
Make more fields final
7cfa5c3
@Doomsdayrs
Remove empty method from AsteroidBleManager
244854c
@Doomsdayrs
Remove unnecessary imports
6e4974c
@Doomsdayrs
Replace <BluetoothDevice> wi <> in DeviceListFrag arraylist declaration
9eb6ccf
@Doomsdayrs
Replace Anonymous type with lamba
ded3ab4
@Doomsdayrs
Replace Collections.sort with list.sort
a53d58f
@Doomsdayrs
Make AppInfoAdapter.MyOnItemSelectedListener static
ffb7627
@Doomsdayrs
Add nullability annotations
90c6e65
@Doomsdayrs
Use requireActivity in DeviceDetailFragment
93bd282
@Doomsdayrs
mDetailFragment = not null in MainActivity.onDefaultDeviceSelected
ad474ed
@Doomsdayrs
Use requireActivity & requireContext in WeatherSettingsFragment
073a1cf
@Doomsdayrs
Inline supported boolean in AsteroidBleManager
8a49a13
@Doomsdayrs
Remove redundant default value for msgType & id in Notification
27eb2d1
@Doomsdayrs
Copy link
Contributor Author

None of this changes any behavior except maybe 4e9642d , because Handlers occur on the main loop and well.

@Doomsdayrs
Copy link
Contributor Author

Doomsdayrs commented Feb 7, 2023 •
edited
Loading

This or #189 can be merged, the changes are included in both

@Doomsdayrs Doomsdayrs mentioned this pull request Feb 7, 2023
Closed
jrtberlin
jrtberlin requested changes Feb 7, 2023
View reviewed changes
Copy link
Member

@jrtberlin jrtberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
The changes I want to see are very minor, and in general this is a great contribution!

app/src/main/java/org/asteroidos/sync/services/NLService.java Show resolved Hide resolved
app/src/main/java/org/asteroidos/sync/utils/AppInfoHelper.java Outdated Show resolved Hide resolved
.idea/copyright/GPLv3.xml Show resolved Hide resolved
.idea/copyright/profiles_settings.xml Show resolved Hide resolved
AUTHORS Outdated Show resolved Hide resolved
@librarydemise457892 librarydemise457892 mentioned this pull request Feb 8, 2023
Closed
@Doomsdayrs Doomsdayrs changed the title Various Improvements Android 13 & Various Improvements Feb 17, 2023
@Doomsdayrs Doomsdayrs requested a review from jrtberlin February 17, 2023 03:07
jrtberlin
jrtberlin approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@jrtberlin jrtberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the PR!

@jrtberlin jrtberlin merged commit 5544f46 into AsteroidOS:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrtberlin jrtberlin jrtberlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Doomsdayrs @jrtberlin