Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tailwindcss): add root_dir detection to tailwindcss pack #912

Merged
merged 2 commits into from
Apr 25, 2024
Merged

fix(tailwindcss): add root_dir detection to tailwindcss pack #912

merged 2 commits into from
Apr 25, 2024

Conversation

rafaelderolez
Copy link
Contributor

📑 Description

The tailwindcss-language-server is currently always up and running. I believe it should only run when a Tailwind CSS config is found.

This PR fixes that.

ℹ Additional Information

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited by mehalter
Loading

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@rafaelderolez rafaelderolez changed the title fix(pack): add root_dir detection to tailwindcss pack fix(tailwindcss): add root_dir detection to tailwindcss pack Apr 25, 2024
@rafaelderolez @mehalter
Update lua/astrocommunity/pack/tailwindcss/init.lua
e3502bf 
Co-authored-by: Micah Halter <micah@mehalter.com>
@mehalter mehalter merged commit 364a595 into AstroNvim:main Apr 25, 2024
12 checks passed
@astronvimbot astronvimbot mentioned this pull request Apr 25, 2024
Merged
@natematykiewicz natematykiewicz mentioned this pull request Apr 25, 2024
Merged
@rafaelderolez rafaelderolez deleted the dev-tailwindcss-conditional-setup branch April 26, 2024 18:12
@nemmtor nemmtor mentioned this pull request Jun 24, 2024
Merged
treshenry added a commit to treshenry/astrocommunity that referenced this pull request Sep 7, 2024
@treshenry
fix(tailwindcss): fix TailwindCSS pack not loading in Phoenix projects
1102907 
See also AstroNvim#915

Phoenix projects put the tailwind.config.js file in the root /assets
folder. The addition of specific root dir detection in AstroNvim#912 broke the
elixir-phoenix pack.
@treshenry treshenry mentioned this pull request Sep 7, 2024
Merged
Uzaaft pushed a commit that referenced this pull request Sep 9, 2024
@treshenry
fix(tailwindcss): fix TailwindCSS pack not loading in Phoenix projects (
5b25511 
#1196)

See also #915

Phoenix projects put the tailwind.config.js file in the root /assets
folder. The addition of specific root dir detection in #912 broke the
elixir-phoenix pack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehalter mehalter mehalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelderolez @mehalter