Skip to content

Commit

Permalink
add role and group review tabs (#2446)
Browse files Browse the repository at this point in the history
* add role and group review tabs
* reword tab labels and style
---------

Signed-off-by: jtsang01 <jimmy.tsang@yahooinc.com>
Co-authored-by: jtsang01 <jimmy.tsang@yahooinc.com>
  • Loading branch information
jimmytsang and jtsang01 authored Dec 6, 2023
1 parent a79ebb8 commit 4b6a7f6
Show file tree
Hide file tree
Showing 22 changed files with 3,859 additions and 247 deletions.
216 changes: 108 additions & 108 deletions ui/src/__tests__/components/review/__snapshots__/ReviewTable.test.js.snap

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

20 changes: 17 additions & 3 deletions ui/src/__tests__/pages/workflow/__snapshots__/admin.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1406,7 +1406,7 @@ exports[`PendingApprovalPage should render 1`] = `
<div
class="emotion-30 emotion-31"
>
Pending Items for Approval
Action Required
</div>
<div
class="emotion-32 denali-tab-group"
Expand All @@ -1416,13 +1416,27 @@ exports[`PendingApprovalPage should render 1`] = `
class="emotion-33 denali-tab active"
data-active="true"
>
Admin View
<span
style="text-align: center;"
>
Pending Members Approval
<br />
(
Admin View)
</span>
</div>
<div
class="emotion-33 denali-tab"
data-active="false"
>
Domain View
<span
style="text-align: center;"
>
Pending Members Approval
<br />
(
Domain View)
</span>
</div>
</div>
</div>
Expand Down
20 changes: 17 additions & 3 deletions ui/src/__tests__/pages/workflow/__snapshots__/domain.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -1519,7 +1519,7 @@ exports[`PendingApprovalPage should render 1`] = `
<div
class="emotion-30 emotion-31"
>
Pending Items for Approval
Action Required
</div>
<div
class="emotion-32 denali-tab-group"
Expand All @@ -1529,13 +1529,27 @@ exports[`PendingApprovalPage should render 1`] = `
class="emotion-33 denali-tab"
data-active="false"
>
Admin View
<span
style="text-align: center;"
>
Pending Members Approval
<br />
(
Admin View)
</span>
</div>
<div
class="emotion-33 denali-tab active"
data-active="true"
>
Domain View
<span
style="text-align: center;"
>
Pending Members Approval
<br />
(
Domain View)
</span>
</div>
</div>
</div>
Expand Down
Loading

0 comments on commit 4b6a7f6

Please sign in to comment.