for groups to disable expiry notfs look for both expiration/reminder tags #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For role members, we're looking for zms.DisableExpirationNotifications tags for disabling expiration notifications and zms.DisableReminderNotifications for disabling review reminder notifications.
For group members, we don't have review reminder - only expirations. However, the code was looking for zms.DisableReminderNotifications tag to disable expiration notifications which is inconsistent with role members.
So the code now looks at both tags for group members. zms.DisableExpirationNotifications is the correct tag name and zms.DisableReminderNotifications for backward compatibility
Description
Contribution Checklist:
Attach Screenshots (Optional)