update service provider manager test case #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
| @@ -64,7 +62,7 @@ public void clean() { | |||
| public void testIsServiceProvider() throws InterruptedException, ExecutionException { | |||
| String testDomainName = "test.domain"; | |||
| String testRoleName = "test_role"; | |||
| long fetchFrequency = 1L; // For the test, fetch every second | |||
| long fetchFrequency = 5L; // For the test, fetch every second | |||
There was a problem hiding this comment.
Should we update the comment accordingly?
There was a problem hiding this comment.
Yes, thanks.updated the comment
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
abvaidya
approved these changes
Nov 9, 2023
abvaidya
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the test case sets up provider list update every second, but it's possible if the build system is slow, the 10 threads verifying the list don't finish within a second before the list is refreshed. now, it's set to 5 secs so plenty of time for threads to complete their tasks.
Contribution Checklist:
Attach Screenshots (Optional)