support max member limit on roles and groups #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
| @@ -90,6 +90,7 @@ CREATE TABLE IF NOT EXISTS `zms_server`.`role` ( | |||
| `group_expiry_days` INT NOT NULL DEFAULT 0, | |||
| `description` VARCHAR(4096) NOT NULL DEFAULT '', | |||
| `delete_protection` TINYINT(1) NOT NULL DEFAULT 0, | |||
| `max_members` INT NOT NULL DEFAULT 0, | |||
There was a problem hiding this comment.
Should we have some other numbers as the default value instead of 0?
There was a problem hiding this comment.
No, we can't introduce backward incompatible changes. Value of 0 indicates there is no limit which is the current behavior.
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
| // so at this point we know that we'll be adding a new member to the | ||
| // role. so first let's count the number of role members | ||
|
|
||
| int roleMemberCount = con.countRoleMembers(domainName, roleName); |
There was a problem hiding this comment.
Is it meant to count the expired members also as valid role/group member in terms of count?
There was a problem hiding this comment.
yes, the count includes everyone regardless if they're expired or not
chandrasekhar1996
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support max member limit on roles and groups
Contribution Checklist:
Attach Screenshots (Optional)