support domain (security) point of contact fields #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jtsang01 <jimmy.tsang@yahooinc.com>
jimmytsang
changed the title
jchen05-yh
reviewed
Feb 22, 2024
| import RequestUtils from '../utils/RequestUtils'; | ||
|
|
||
| const SectionsDiv = styled.div` | ||
| width: 760px; |
There was a problem hiding this comment.
Would max-width make it responsive?
There was a problem hiding this comment.
the styling properties are copied from add member modal, just tested the AddPoc modal is responsive to window resize.
ui/src/components/member/AddPoc.js
Outdated
| 'Updating Point of Contact ' + | ||
| this.state.pocName + | ||
| ' for domain ' + | ||
| this.props.domain; |
There was a problem hiding this comment.
Maybe consider using Updating Point of Contact ${this.state.pocName} for domain ${this.props.domain}?
There was a problem hiding this comment.
good suggestion, fixed
Signed-off-by: jtsang01 <jimmy.tsang@yahooinc.com>
dantewuuuuu
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces the new configurable domain meta fields "Point of Contact" and "Security Point of Contact"
Key files to review