fetch verification key from server via proxy during accesstoken and roletoken verification #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Go Yakami <gyakami@lycorp.co.jp> Signed-off-by: Toshiaki Aoike <taoike@lycorp.co.jp> Signed-off-by: Shimpei Yamazaki <shimyama@lycorp.co.jp>
havetisyan
requested changes
Feb 27, 2024
clients/java/zpe/pom.xml
Outdated
| @@ -31,7 +31,7 @@ | |||
| <mock.server.version>5.15.0</mock.server.version> | |||
| <commons.io.version>2.15.1</commons.io.version> | |||
| <uberjar.name>benchmarks</uberjar.name> | |||
| <code.coverage.min>0.8702</code.coverage.min> | |||
| <code.coverage.min>0.8682</code.coverage.min> | |||
There was a problem hiding this comment.
any reason why we're reducing our code coverage? please review your additions to make sure all the new code is included in the tests.
we only allow reducing the code coverage if you're removing functions from the module which doesn't seem to be the case here.
There was a problem hiding this comment.
We modified the implementation of setAccessTokenSignKeyResolver in AuthZpeClient.java to restore coverage.
Signed-off-by: Kubiura Hiromu <hkubiura@yahoo-corp.jp>
|
@havetisyan |
havetisyan
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, we have enabled the use of a proxy URL when retrieving the verification key during the validation of accesstoken and roletoken.
Contribution Checklist: