Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to not omit the user domain when completion search result is empty #2532

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

hiragi-gkuth
Copy link
Contributor

Description

We are utilizing Athenz with identical strings set for both user domain and home domain. Consequently, since the member completion search in AthenzUI returns results without the user domain, it becomes impossible to add RoleMembers or GroupMembers that begin with the user domain.

For instance, if both userdomain and homedomain are personal:

  1. I attempt to add personal.hiragi-gkuth.subdomain.test-service
  2. The AddMember.js modal for completion suggests hiragi-gkuth.subdomain.test-service as the result.
  3. I'm unable to add hiragi-gkuth.subdomain.test-servic because it is not exists.

Therefore, I have made a fix ensuring that the AddMember completion returns exactly the input text when the search result is empty.

Contribution Checklist:

  • The pull request does not introduce any breaking changes
    • This PR has breaking changes, but it doesn't looks so critical.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

Signed-off-by: Shimaoka Shuya <sshimaok@lycorp.co.jp>
@hiragi-gkuth hiragi-gkuth changed the title fix to don't omit user domain when completion search result is empty fix to not omit the user domain when completion search result is empty Feb 29, 2024
@havetisyan havetisyan merged commit 3411207 into AthenZ:master Feb 29, 2024
2 checks passed
@hiragi-gkuth hiragi-gkuth deleted the fix-athenzui-completion branch March 1, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants