Adding provider interface for fetching public keys of a service #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havetisyan
requested changes
Mar 13, 2024
| @@ -64,6 +64,9 @@ type Provider interface { | |||
| // GetSuffix returns the suffix for the current provider | |||
| GetSuffix() string | |||
|
|
|||
| // GetSuffixes returns a list of suffixes for the current provider | |||
| GetSuffixes() []string | |||
There was a problem hiding this comment.
why keep the GetSuffix() api? since this is an internal interface for now and only used within the server, we can just update all the provider implementations to use GetSuffixes() instead of maintaining a deprecated api
| @@ -0,0 +1,19 @@ | |||
| package com.yahoo.athenz.common.server.key; | |||
There was a problem hiding this comment.
need the copyright header block
| @@ -0,0 +1,28 @@ | |||
| package com.yahoo.athenz.common.server.key; | |||
There was a problem hiding this comment.
need the copyright header block
| } | ||
|
|
||
| for (ServiceIdentity serviceIdentity: domainData.getServices()) { | ||
| if (serviceIdentity.getName().equalsIgnoreCase(domain + "." + service)) { |
There was a problem hiding this comment.
we should move the "domain + "." + service" outside of the for block so we're not executing for every call in the iteration since the value does not change
psasidhar
force-pushed
the
spl-pvdr
branch
3 times, most recently
from
1b93b23
to
f583b25
Compare
Signed-off-by: Sasi Palaka <palakas@yahooinc.com>
havetisyan
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a provider interface for fetching public keys of a service
Extending Go provider interface with GetSuffixes method
Contribution Checklist:
Attach Screenshots (Optional)