sia: set service cert and key in role option #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: craman <chandrasekhar.raman@yahooinc.com>
chandrasekhar1996
force-pushed
the
optionRole
branch
from
7f6bb42
to
50708bd
Compare
havetisyan
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the generateRoleKey is set to false then the expectation is RoleKeyFileName will be empty and we should use SvcKeyFileName to get the key to be used with role certificate, but svcKeyFileName is set only when user provides a key file name for svc in their config
The update is to set the svcKeyFileName and svcCertFileName using the util function to ensure the value is always populated
Contribution Checklist:
Attach Screenshots (Optional)