Jonmv/assume azure services #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jonmv <venstad@gmail.com>
Signed-off-by: jonmv <venstad@gmail.com>
Signed-off-by: jonmv <venstad@gmail.com>
Signed-off-by: jonmv <venstad@gmail.com>
Signed-off-by: jonmv <venstad@gmail.com>
Signed-off-by: jonmv <venstad@gmail.com>
Signed-off-by: jonmv <venstad@gmail.com>
Signed-off-by: jonmv <venstad@gmail.com>
Signed-off-by: jonmv <venstad@gmail.com>
Signed-off-by: jonmv <venstad@gmail.com>
Signed-off-by: jonmv <venstad@gmail.com>
havetisyan
requested changes
Jun 4, 2024
...ovider/src/main/java/com/yahoo/athenz/instance/provider/impl/AzureVmUserManagedIdentity.java
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| /* For some reason, the close method is called after each confirmInstance, but the provider is reused, so we can't actually close it. |
There was a problem hiding this comment.
can you please open up an issue for this. it doesn't look right and we need to fix it.
There was a problem hiding this comment.
It's because the InstanceAzureProvider used to be a HTTP-type provider, and those are created (and closed) for each request. I think I'll just remove the close here (the default method is empty).
Signed-off-by: jonmv <venstad@gmail.com>
havetisyan
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work in this PR consists of three main contributions, where the first enables the other two:
Contribution Checklist:
InstanceAzureProviderwas not in use by others. This is the only breaking change.