Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fix: group review submitted for wrong domain #2655

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

chandrasekhar1996
Copy link
Contributor

Description

When submitting review for groups through UI, the domain name used is wrong which led to the review being submitted for the wrong domain (if group names are same) or no review being submitted since domain+group name is an invalid combination.
Fix for this is for the component to pass the domainName as well instead of relying on redux store to find out the domainName.

The changes are only in

src/redux/thunks/groups.js
src/components/group/GroupReviewTable.js
src/__tests__/redux/thunk/groups.test.js

Remaining changes are from npm run fix-lint

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

Signed-off-by: craman <chandrasekhar.raman@yahooinc.com>
@havetisyan havetisyan merged commit fc8b1a8 into AthenZ:master Jul 12, 2024
2 checks passed
@chandrasekhar1996 chandrasekhar1996 deleted the reviewBug branch July 12, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants