Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add role member UI enhancement #2700

Merged
merged 1 commit into from
Aug 23, 2024
Merged

add role member UI enhancement #2700

merged 1 commit into from
Aug 23, 2024

Conversation

ArtjomsPorss
Copy link
Contributor

Description

Changes to Add Role Member modal behaviour. In particular:

  1. When dropdown appears - first item is automatically highlighted. Pressing Enter selects it.
  2. When dropdown option is selected - text in the input will appear in bold.
  3. Clicking anywhere outside input, while there is text in the input - does not remove/replace text in the input.
  4. Changing text in the input while after dropdown option was selected - clears the selected dropdown option. This is to make sure only options selected in the dropdown are submitted and to prevent situations where user submits selected options that don't match text in the input.

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

Video containing displaying all 4 changes:
https://github.com/user-attachments/assets/59ab6165-30e4-4de5-9e5d-b6f7ee995680

@ArtjomsPorss ArtjomsPorss marked this pull request as ready for review August 21, 2024 09:23
@ArtjomsPorss ArtjomsPorss changed the title ATHENS-7438 add role member UI enhancement add role member UI enhancement Aug 21, 2024
@ArtjomsPorss
ATHENS-7438 add role member UI enhancement
d1dde9a 
Signed-off-by: aporss <art.porss@yahooinc.com>
@ArtjomsPorss ArtjomsPorss deleted the add-role-member-ux branch August 23, 2024 15:31
@ArtjomsPorss ArtjomsPorss restored the add-role-member-ux branch August 23, 2024 16:04
@ArtjomsPorss ArtjomsPorss reopened this Aug 23, 2024
chandrasekhar1996
chandrasekhar1996 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@chandrasekhar1996 chandrasekhar1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@abvaidya abvaidya merged commit 0c7294c into AthenZ:master Aug 23, 2024
2 checks passed
havetisyan added a commit that referenced this pull request Sep 5, 2024
@havetisyan
merge #2700, #2703 and #2705 from master to jetty 1.12.x branch
ecea51d 
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
havetisyan added a commit that referenced this pull request Sep 5, 2024
@havetisyan
merge #2700, #2703 and #2705 from master to jetty 1.12.x branch (#2713)
3f3221f 
* merge #2700, #2703 and #2705 from master to jetty 1.12.x branch

---------

Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandrasekhar1996 chandrasekhar1996 chandrasekhar1996 approved these changes

@abvaidya abvaidya abvaidya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArtjomsPorss @abvaidya @chandrasekhar1996