Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diplay service provider error message #2761

Merged

Conversation

ArtjomsPorss
Copy link
Contributor

@ArtjomsPorss ArtjomsPorss commented Oct 8, 2024

Description

when user clicks 'Allow' for a Provider on a Services screen and user is not authorised to allow it, the corresponding error message from backend should be displayed

  • added column to provider table to display error message
  • removed code that replaced whole providers table with an error, instead error is displayed in the table, to the right on the provider that causes it
  • added some IDs to ui elements to ease writing of functional tests
  • added functional test

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Attach Screenshots (Optional)

Signed-off-by: aporss <art.porss@yahooinc.com>
@ArtjomsPorss ArtjomsPorss marked this pull request as ready for review October 8, 2024 21:00
@havetisyan havetisyan merged commit 3f5dea1 into AthenZ:master Oct 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants