fix functional tests in services.spec #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aporss <art.porss@yahooinc.com>
ArtjomsPorss
commented
Oct 25, 2024
Comment on lines
+59
to
+61
| expect( | ||
| url.includes('athenz-guide') || url.includes('yo/service-instances') | ||
| ).toBe(true); |
There was a problem hiding this comment.
url can be either depending on whether the test is run locally or via SD
ArtjomsPorss
commented
Oct 25, 2024
| @@ -82,35 +84,28 @@ describe('services screen tests', () => { | |||
| await modalDeleteButton.click(); | |||
| }); | |||
|
|
|||
| describe('services screen tests', () => { | |||
There was a problem hiding this comment.
duplicate 'describe' declaration removed, so most of the change here is just indentation fix
ArtjomsPorss
commented
Oct 25, 2024
Comment on lines
-92
to
+91
| let domain = 'athenz.dev.test-non-admin'; | ||
| let testDomain = await $(`a*=${domain}`); | ||
| await browser.waitUntil(async () => await testDomain.isClickable()); | ||
| await testDomain.click(); | ||
| it('when clicking "Allow" button on a provider without having appropriate authorisation, the error should be displayed to the right of the button', async () => { | ||
| await console.log(`testtesttest inside second test`) | ||
| // open browser | ||
| await browser.newUser(); | ||
| await browser.url(`/domain/athenz.dev.test-non-admin/role`); |
There was a problem hiding this comment.
fix of the second test - navigate to domain directly via url, since the user is not its memeber and thus domain is not visible in the list of domains on the right in ui
havetisyan
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix of 2 functional tests
Contribution Checklist: