Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace Math.random() with crypto.randomBytes() #452 #474

Merged
merged 1 commit into from
May 23, 2018
Merged

replace Math.random() with crypto.randomBytes() #452 #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions libs/nodejs/auth_core/src/util/Crypto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
var crypto = require('crypto');
var ybase64 = require('./YBase64');

var SALT_LENGTH = 8;
var SALT_CHARS = '0123456789abcdef';
var SALT_BYTES = 4;

class Crypto {
static hmac(message, sharedSecret) {
Expand Down Expand Up @@ -52,12 +51,8 @@ class Crypto {
}

static randomSalt() {
var c, i, salt = '';
for (c = 0; c < SALT_LENGTH; c++) {
i = Math.floor(Math.random() * SALT_CHARS.length);
salt += SALT_CHARS.charAt(i);
}
return salt;
var salt = crypto.randomBytes(SALT_BYTES);
return salt.toString('hex');
}
}

Expand Down