Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

WIP: Fixing #3 - Chrome Web Store Policy fix and Chrome Extension Manifest v3 bump #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

antivirtel
Copy link

Adding new functionality:

  • fetch the top X headlines
  • move to Chrome manifest v3

@antivirtel antivirtel changed the title Fixing #3 WIP: Fixing #3 - Chrome Web Store Policy fix and Chrome Extension Manifest v3 bump Jun 20, 2021
@antivirtel
Copy link
Author

Hi, this is still WIP, just trying to upload something already. Having trouble with using JS fetch().
I get this:

Failed to load resource: the server responded with a status of 401 (Unauthorized)

So it doesn't seem like it's accepting the cookies, or the JS fetch() doesn't pick them up, I used this as you can see it in the code:

fetch(fetch_url, {credentials: "include", mode:'no-cors'})

Never used it before, neither touched a Chrome Extension before @Athou . Any suggestions? Thanks!

@Athou
Copy link
Owner

Athou commented Jun 22, 2021

I don't know :( When I wrote the extension, fetch() didn't exist yet and I had to use the old XMLHttpRequest API, which passed the cookies correctly (see https://github.com/Athou/commafeed-chrome/blob/master/background.js#L7)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants