Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tibble for outputs #118

Closed
daxkellie opened this issue Dec 21, 2021 · 0 comments
Closed

Use tibble for outputs #118

daxkellie opened this issue Dec 21, 2021 · 0 comments

Comments

@daxkellie
Copy link
Contributor

With our push to embrace dplyr syntax, it may be best to return tibbles not only in show_all_fields (#110), but for all functions that return a data.frame for consistency. Old syntax will remain as before and return data as a data.frame
daxkellie added a commit that referenced this issue Dec 21, 2021
@daxkellie
Make show_all_ functions return as tibbles (#110, #118))
1d13e01
mjwestgate added a commit that referenced this issue Dec 23, 2021
@mjwestgate
update galah_ functions to return tibbles (#118)
14957d4
mjwestgate added a commit that referenced this issue Jan 4, 2022
@mjwestgate
add find_taxa function to take place of `search_taxa(..., is_id = T…
5aa8a46 
…RUE)`

- `search_taxa` and `find_taxa` are now in different files, containing only their supporting functions, for easier maintanence
- Both functions support revised behaviour of `atlas_GET` and so do not return errors or warnings resulting from failed web calls (#119)
- Both functions always return a `tibble`; empty if no data are available (#118)
- non-exported functions `intermediate_ranks` and `child_concepts` have been removed
- misc updated tests and fixtures
- deprecated `select_taxa` retains `is_id` for backwards compatability
mjwestgate added a commit that referenced this issue Jan 4, 2022
@mjwestgate
create new function set_galah_object_class for easy enforcement of …
8b957a0 
…OOP (and tibbles as per #118)

This function:
- checks for a supplied object, and if it isn't given, creates a tibble
- checks if supplied object is a tibble, and if not, converts it
- adds the specified class to existing class list
this new framework has been applied to `search_taxa` and `find_taxa`, but may be useful elsewhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daxkellie