Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to automatically URL encode the room name if required #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

markwragg
Copy link
Collaborator

@markwragg markwragg commented Mar 17, 2024

This PR is to address issue #4 to automatically handle room name encoding for the -room parameter.

Description

Uses the [system.web.httputility] class to perform a URLdecode (in case the user has already done URL encoding) and then re-encode it. Has a try catch around it so if the class is not available it will continue to work without having modified $room, but prints a warning. I'm not sure how backwards compatible [system.web.httputility] is, but its available on PS7 under MacOS.

Motivation and Context

Closes #4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@markwragg markwragg requested review from a team as code owners March 17, 2024 16:52
@markwragg
Copy link
Collaborator Author

I know the issue raised for this is really old, but I'm clearing down old issues in my name and it seemed like an easy one to implement in case it is of use to anyone. Note I don't personally still use Hipchat so i'm not able to perform any real world testing unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow $room to be entered unencoded and urlencode it
1 participant