Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed handling of server responses with an error #303

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Fixed handling of server responses with an error #303

merged 1 commit into from
Jul 17, 2018

Conversation

lipkau
Copy link
Member

@lipkau lipkau commented Jul 16, 2018

Description

  • error objects are now converted to a string and displayed properly
  • Functions which use a property of the response will ignore the result if empty

Motivation and Context

closes #302

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@lipkau
Fixed handling of server responses with an error
b6ed04b 
* error objects are now converted to string and displyed properly
* Functions which use a property of the response will ignore the result if empty
@lipkau lipkau self-assigned this Jul 16, 2018
@lipkau lipkau requested review from a team as code owners July 16, 2018 07:09
@ghost ghost added the Status:In Review label Jul 16, 2018
FriedrichWeinmann
FriedrichWeinmann approved these changes Jul 17, 2018
View reviewed changes
Copy link

@FriedrichWeinmann FriedrichWeinmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable enough

@lipkau lipkau merged commit 22f7310 into AtlassianPS:master Jul 17, 2018
@ghost ghost removed the Status:In Review label Jul 17, 2018
@lipkau lipkau deleted the fix/#302-HandlingOfErrorResponses branch July 17, 2018 18:09
@lipkau lipkau mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriedrichWeinmann FriedrichWeinmann FriedrichWeinmann approved these changes

Assignees

@lipkau lipkau

Labels
Area:Module Issue:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misbehavior when cmdlet fails
2 participants
@lipkau @FriedrichWeinmann