Get-JiraUser -Filter parameter added #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new parameter, -Filter, has been added which returns information on all users matching the supplied text. The meaning of the existing -UserName parameter has been modified. It now returns the user whose username is the supplied text.
ghost
added
the
|
As this changes the behavior of what the functions returns, this has been tagged as breaking change. |
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get-JiraUser tries to be too helpful, sometimes returning multiple users when a unique Jira username was specified. This is as a result of always searching for matching users when the -UserName parameter is specified.
This PR modifies Get-JiraUser in line with the suggestion in #49. The existing -UserName parameter meaning is changed. It no longer searches and now returns only a single user with an exactly matching username.
A new parameter, -Filter, has been added which provides the search capability previously provided by -UserName.
For a single user, one server round trip is now saved when using -UserName, as groups are expanded in the initial call.
Outstanding Questions
I was not sure of the best behaviour for pipeline input. Suggestions and comments appreciated.
Motivation and Context
closes #49
Types of changes
Checklist: