Fix issue 229 - New-JiraIssue should take params from pipeline. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue was due to begin and end blocks using params. Added test for params from pipeline.
ghost
added
the
lipkau
requested changes
Sep 21, 2018
JiraPS/Public/New-JiraIssue.ps1
Outdated
| [PSCustomObject] | ||
| $Fields, | ||
|
|
||
| [Parameter()] | ||
| [Parameter( ValueFromPipelineByPropertyName )] |
There was a problem hiding this comment.
Credential is not part of any object that can be used in the pipeline.
please remove this change
JiraPS/Public/New-JiraIssue.ps1
Outdated
| [System.Management.Automation.PSCredential] | ||
| [System.Management.Automation.Credential()] | ||
| $Credential = [System.Management.Automation.PSCredential]::Empty | ||
| ) | ||
|
|
||
| begin { | ||
| } | ||
|
|
||
| process { | ||
| Write-Verbose "[$($MyInvocation.MyCommand.Name)] Function started" |
There was a problem hiding this comment.
Please leave the Write-Verbose of the beginning in the begin block
Removed credential from param by pipeline.
lipkau
approved these changes
Sep 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The here was due to how PowerShell handles input via the pipeline, see an in depth explanation with examples here: https://learn-powershell.net/2013/05/07/tips-on-implementing-pipeline-support/.
The function will be unable to use $Profile in the begin block, so i moved that code into the Process block. This is necessary so that multiple new issues can be passed in and processed one after the other.
Motivation and Context
This resolves #229 and allows a user to fill an excel sheet or other object with new issues and pipe them into new issue.
closes #229
Types of changes
Checklist: