Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Move-JiraVersion method #363

Merged
merged 5 commits into from
Jul 20, 2019
Merged

Add Move-JiraVersion method #363

merged 5 commits into from
Jul 20, 2019

Conversation

kb-cs
Copy link
Contributor

@kb-cs kb-cs commented Jul 19, 2019 •
edited
Loading

Description

Add Move-JiraVersion method

Motivation and Context

/version/{id}/move was missing from current functionality

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@kb-cs kb-cs requested review from a team as code owners July 19, 2019 18:44
@lipkau
Copy link
Member

lipkau commented Jul 20, 2019

excellent PR!

can you please commit a test file? I can support you if desired.

@kb-cs
Copy link
Contributor Author

kb-cs commented Jul 20, 2019

I added unit tests. Never done PS unit tests, but it was easy enough to follow the others.
Let me know if anything is off.

lipkau
lipkau approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@lipkau lipkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this

@lipkau lipkau changed the base branch from master to develop July 20, 2019 20:36
@lipkau lipkau merged commit 31b3a99 into AtlassianPS:develop Jul 20, 2019
@lipkau lipkau added this to the v2.11 milestone Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipkau lipkau lipkau approved these changes

Assignees

@kb-cs kb-cs

Labels
Area:Module Issue:Enhancement
Projects
None yet
Milestone
v2.11
Development

Successfully merging this pull request may close these issues.
3 participants
@kb-cs @lipkau @lmf-mx