Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround: fix #404 updating api for user data #409

Merged
merged 3 commits into from
Mar 28, 2020

Conversation

lipkau
Copy link
Member

@lipkau lipkau commented Mar 22, 2020

Description

workaround
temporarily changed api routes to use version 2.
This should be reverted to version latest as soon as a proper handling of how users work between cloud and on-premise is implemented

Motivation and Context

closes #404

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@lipkau lipkau requested review from a team as code owners March 22, 2020 13:24
@lipkau lipkau self-assigned this Mar 22, 2020
brianbunke
brianbunke previously approved these changes Mar 22, 2020
Copy link
Contributor

@brianbunke brianbunke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lipkau lipkau force-pushed the fix/#404-UpdatingApiForUserData branch from 4204bed to f7e04b7 Compare March 23, 2020 07:45
@lipkau lipkau dismissed brianbunke’s stale review March 28, 2020 09:24

The base branch was changed.

@lipkau lipkau changed the base branch from master to develop March 28, 2020 09:24
@lipkau lipkau merged commit 1f243a2 into AtlassianPS:develop Mar 28, 2020
@lipkau lipkau deleted the fix/#404-UpdatingApiForUserData branch March 28, 2020 09:32
@alexsuslin
Copy link
Contributor

don't you think there will be much more issues with latest rather than certain number? I guess it should be exact api number by default and chaging it is a major change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot get or set assignee of issues
3 participants