Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Add-JiraGroupMember so that it honors ErrorAction #426

Merged
merged 2 commits into from
Jan 23, 2021

Conversation

spascoe
Copy link
Contributor

@spascoe spascoe commented Nov 5, 2020

Description

In Add-JiraGroupMember.Unit.Tests.ps1, these two tests require the Add-JiraGroupMember to handle the supplied ErrorAction parameter:

  • "Tests to see if a provided user is currently a member of the provided JIRA group before attempting to add them"
  • "Gracefully handles cases where a provided user is already in the provided group"

I switched the Write-Error to WriteError and adjusted the splat parameter to supply the necessary parameters

Motivation and Context

This change is necessary to enable the tests to pass.
closes #425

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@spascoe spascoe requested review from a team as code owners November 5, 2020 22:30
@lipkau lipkau merged commit 948718a into AtlassianPS:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add-JiraGroupMember Test not passing on Windows PWSH5, PWSH7
2 participants