fix: classname placement on Input #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LimeWub
force-pushed
the
fix/input-classname-placement
branch
from
d8c958e to
09d3c91
Compare
LimeWub
requested review from
Mhoog,
Marcdup1,
mzeenkala23,
miaambt,
a team and
CarlosTrapet
and removed request for
a team
LimeWub
changed the base branch from
main
to
feat/focus-visible-style-block-allow-boxShadow-to-be-passed-in
Marcdup1
approved these changes
Sep 18, 2024
Mhoog
approved these changes
Sep 18, 2024
Base automatically changed from
feat/focus-visible-style-block-allow-boxShadow-to-be-passed-in
to
main
September 18, 2024 10:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classNames passed intoInputwere being added toInputText(the field) and not the wrappingInputBackground.This is a problem when it comes to adding spacing or handling sizing either with
styledorcssfrom the parent as it skips a div.Placement on the
InputBackgroundwhich is the outer element should be more correct.The
SearchInputcomponent was affected by this change, with the area where the icon is placed not being clickable anymore (click through to input for edit). This was amended via slight restructuring and now the component should have no visual or functional changes. ( 4a5f1ca )This work is required for PR: #703