Feat: Allow CSS overrides for TopBar wrapper element #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andoulla
approved these changes
Oct 14, 2024
LimeWub
reviewed
Oct 14, 2024
LimeWub
reviewed
Oct 16, 2024
LimeWub
approved these changes
Oct 16, 2024
avirati
deleted the
HMP-1179-ds-update-top-bar-tsx-and-allow-css-overrides
branch
avirati
added a commit
that referenced
this pull request
Oct 18, 2024
Revert "Merge pull request #710 from Atom-Learning/HMP-1179-ds-update…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://atomlearningltd.atlassian.net/browse/HMP-1178
We encountered a bug last week where TopBar was not rendering well with other elements in the page
Upon investigation, we found out that overriding z-index of the root of TopBar component fixed the issue. However, it was done so by forcing the override from outside. This PR enables css overrides for root / wrapper element of TopBar. After this is released, we will remove the forced override and pass the required css as a prop instead.
More information - https://github.com/Atom-Learning/atom-core/pull/10161