Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/visual regression #713

Merged
merged 22 commits into from
Dec 19, 2024
Merged

Feat/visual regression #713

merged 22 commits into from
Dec 19, 2024

Conversation

avirati
Copy link
Contributor

@avirati avirati commented Nov 5, 2024 •
edited
Loading

The following was done as part of this PR -

  1. Setup Playwright
  2. Add Visual Regression spec to crawl documentation site and take screenshot
  3. Add Github workflow file for running visual regression tests on push to main and on PRs with label visual-regression
  4. Add missing concurrency for test workflow

@avirati avirati mentioned this pull request Nov 5, 2024
Merged
@avirati avirati force-pushed the feat/visual-regression branch from 670f3da to 4b2a284 Compare December 17, 2024 10:32
@avirati avirati added the visual-regression Run Visual Regression tests label Dec 18, 2024
@argos-ci Argos CI
Copy link

argos-ci bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🔘 Orphan build 158 added Dec 19, 2024, 7:29 AM

@avirati avirati marked this pull request as ready for review December 18, 2024 05:47
chmielsen
chmielsen approved these changes Dec 19, 2024
View reviewed changes
.github/workflows/visual-regression.yml Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
playwright.config.ts Show resolved Hide resolved
@avirati avirati merged commit c061479 into main Dec 19, 2024
3 checks passed
@avirati avirati deleted the feat/visual-regression branch December 19, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andoulla andoulla andoulla approved these changes

@chmielsen chmielsen chmielsen approved these changes

@Mhoog Mhoog Awaiting requested review from Mhoog

@thomasdigby thomasdigby Awaiting requested review from thomasdigby

@Marcdup1 Marcdup1 Awaiting requested review from Marcdup1

@euanhunteratom euanhunteratom Awaiting requested review from euanhunteratom

Assignees
No one assigned
Labels
visual-regression Run Visual Regression tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avirati @chmielsen @andoulla