Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Commit

Permalink
Run linting manually in CI
Browse files Browse the repository at this point in the history
The Atom build-package.sh script only checks `devDependencies` for
linters to run, as ESLint is only listed in our direct `dependencies`
now we need to trigger linting manually.

Includes:
* Minor update to the addon APT packages for Travis CI.
* Structure of the Circle CI script is updated to match that of atom/ci.
* Installing Noide.js on AppVeyor to run ESLint.
  • Loading branch information
Arcanemagus committed Jul 24, 2017
1 parent 72deab9 commit 0e60de5
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 7 deletions.
9 changes: 6 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ env:
- ATOM_CHANNEL=stable
- ATOM_CHANNEL=beta

after_script:
# The Atom CI script doesn't support having ESLint as a direct dependency,
# as such it doesn't run linting automatically for us.
- npm run lint

### Generic setup follows ###
script:
- curl -s -O https://raw.githubusercontent.com/atom/ci/master/build-package.sh
Expand All @@ -32,10 +37,8 @@ sudo: false

addons:
apt:
sources:
- ubuntu-toolchain-r-test
packages:
- g++-6
- build-essential
- fakeroot
- git
- libsecret-1-dev
6 changes: 6 additions & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ environment:
- ATOM_CHANNEL: stable
- ATOM_CHANNEL: beta

after_build:
# The Atom CI script doesn't support having ESLint as a direct dependency,
# as such it doesn't run linting automatically for us.
- cinst nodejs
- npm run lint

### Generic setup follows ###
build_script:
- ps: iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/atom/ci/master/build-package.ps1'))
Expand Down
12 changes: 8 additions & 4 deletions circle.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
test:
dependencies:
override:
- curl -s https://raw.githubusercontent.com/Arcanemagus/ci/atomlinter/build-package.sh | sh
- curl -s -O https://raw.githubusercontent.com/atom/ci/master/build-package.sh
- chmod u+x build-package.sh

dependencies:
test:
override:
- echo "Managed in the script"
- ./build-package.sh
# The Atom CI script doesn't support having ESLint as a direct dependency,
# as such it doesn't run linting automatically for us.
- npm run lint

0 comments on commit 0e60de5

Please sign in to comment.