Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Commit

Permalink
Merge pull request #979 from AtomLinter/arcanemagus/temp-disable-specs
Browse files Browse the repository at this point in the history
Disable specs relying on TextBuffer::onDidReload
  • Loading branch information
Arcanemagus authored Aug 9, 2017
2 parents cd7de8d + efbcd94 commit 6085aad
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions spec/linter-eslint-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,9 @@ describe('The eslint provider for Linter', () => {
expect(messages.length).toBe(2)
}

it('should fix linting errors', async () => {
if (process.env.ATOM_CHANNEL === 'beta') {
// The Atom beta builds currently are broken for onDidReload watching,
// so we just need to skip this test on the beta channel.
return
}
// This spec is broken on Atom v1.19.0!
// See https://github.com/atom/atom/issues/15200 for details
xit('should fix linting errors', async () => {
await firstLint(editor)
await makeFixes(editor)
const messagesAfterFixing = await lint(editor)
Expand Down Expand Up @@ -288,12 +285,9 @@ describe('The eslint provider for Linter', () => {
rimraf.sync(tempDir)
})

it('does not delete the cache file when performing fixes', async () => {
if (process.env.ATOM_CHANNEL === 'beta') {
// The Atom beta builds currently are broken for onDidReload watching,
// so we just need to skip this test on the beta channel.
return
}
// This spec is broken on Atom v1.19.0!
// See https://github.com/atom/atom/issues/15200 for details
xit('does not delete the cache file when performing fixes', async () => {
const tempCacheFile = await copyFileToDir(cachePath, tempDir)
const checkCachefileExists = () => {
fs.statSync(tempCacheFile)
Expand Down

0 comments on commit 6085aad

Please sign in to comment.