Ignore invalid TextEditors for fix jobs

When a fix job is triggered but the TextEditor is invalid by the time the job runs silently return. Fixes #972.
AtomLinter · Aug 9, 2017 · aa609e6 · aa609e6
1 parent cd7de8d
commit aa609e6
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/main.js b/src/main.js
@@ -227,7 +227,12 @@ module.exports = {
   async fixJob(isSave = false) {
     const textEditor = atom.workspace.getActiveTextEditor()
 
-    if (!textEditor || textEditor.isModified()) {
+    if (!textEditor || !atom.workspace.isTextEditor(textEditor)) {
+      // Silently return if the TextEditor is invalid
+      return
+    }
+
+    if (textEditor.isModified()) {
       // Abort for invalid or unsaved text editors
       const message = 'Linter-ESLint: Please save before fixing'
       atom.notifications.addError(message)