This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Clarified disableEslintIgnore description #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just because it amuses me, what do you think about |
|
|
|
Just to be clear, I'm fine with either wording, I just came up with that when looking over the changes. |
|
I think they're both less confusing, but the fact that |
|
Works for me, merging and thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As brought up in #548,
Disable using .eslintignore filesis very ambiguous. It's not clear whether checking the box will "Disable (the use of) .eslintignore files," (which is actually what it's doing) or whether checking the box will "Disable (this package) using .eslintignore files" (which makes it appear to be a bug when this box isn't checked but the package still obeys.eslintignorefiles).