This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Make scopes a configuration setting #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +11,7 @@ module.exports = { | |||
| this.subscriptions = new CompositeDisposable() | |||
| this.active = true | |||
| this.worker = null | |||
| this.scopes = ['source.js', 'source.jsx', 'source.js.jsx', 'source.babel', 'source.js-semantic'] | |||
| this.scopes = atom.config.get('linter-eslint.scopes') | |||
There was a problem hiding this comment.
Maintaining the scopes list isn't quite this simple. Your current code will only update on launching Atom, since that is (generally) the only time the activate() function is called.
You'll need to update this to code like this, so whenever the setting is changed, the scopes array is update (not replaced!) with the new values.
| @@ -11,8 +11,14 @@ module.exports = { | |||
| this.subscriptions = new CompositeDisposable() | |||
| this.active = true | |||
| this.worker = null | |||
| this.scopes = atom.config.get('linter-eslint.scopes') | |||
| this.scopes = new CompositeDisposable() | |||
There was a problem hiding this comment.
this.scopes must be an Array
|
@neurosnap A few more changes needed here. |
|
LGTM and CI is green, merging 😉. Thanks for putting this together! |
|
I'm glad we could get this merged. Thanks for all the input and examples, much appreciated! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow the user to add or remove scopes that will apply to
linter-eslint. The primary reason I am submitting this PR is for https://github.com/rtsao/csjs and by proxy https://github.com/neurosnap/language-csjs which will allow us to extend the linter to this pseudo language.