This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Allow rules to be excluded from fixes #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #791
Description
This adds an option, "Disable specific rules from fixes" which allows users to specify a list of rules which should not be auto-fixed by ESLint. The option is very similar to the already-existing
rulesToSilenceWhileTypingoption, and uses the same strategy of setting--ruleto disable the specified rules.Notes
In the interest of simplicity and avoiding surprises, this option applies to both fixes made during saves, as well as manual fixes run from the command palette.
The spec is largely duplicated from the existing spec for fix jobs, but it didn't make sense to me to try to abstract it out into another function. That would just add some indirection for very little benefit, in my opinion.
This change is