This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Revert #853 #876
Merged
Revert #853 #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yacut The GIF you posted falls under the first path outlined above, are you seeing any cases where the entire file is being replaced and the cursor is actually being restored? |
Arcanemagus
force-pushed
the
arcanemagus/revert-853
branch
2 times, most recently
from
688371b to
605b108
Compare
Arcanemagus
force-pushed
the
arcanemagus/revert-853
branch
2 times, most recently
from
39da031 to
99c235b
Compare
Arcanemagus
force-pushed
the
arcanemagus/revert-853
branch
from
99c235b to
0c32db1
Compare
…ter-fix" This reverts commit 27d5570.
Arcanemagus
force-pushed
the
arcanemagus/revert-853
branch
from
0c32db1 to
d4a1a11
Compare
|
Note, tracking the fix for the likely issue that prompted this initially is here: atom/atom#14189. |
IanVS
approved these changes
May 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #853.
From the testing done so far this code either:
So in either case the code is doing nothing but adding complexity to the codebase.