This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Async-ify the specs #878
Merged
Async-ify the specs #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring in the `jasmine-fix` module and utilize the `async` compatible `beforeEach` and `it` methods it provides. Refactor the code to utilize this instead of the `waitsForPromise` method from the default environment. Includes several fixes to the specs: * Introduce a `getNotification` method to grab the next Notification added to Atom, allowing situations such as waiting on the fix command. * Re-write the `makeFixes` function so it waits on the fix command to finish, including the file changes in Atom before continuing the spec. * Make both fix specs use the same functions so the code isn't duplicated.
😻 |
|
Trying closing/reopening this to see if we can wake Travis-CI up... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring in the
jasmine-fixmodule and utilize theasynccompatiblebeforeEachanditmethods it provides. Refactor the code to utilize this instead of thewaitsForPromisemethod from the defaultenvironment.
Includes several fixes to the specs:
getNotificationmethod to grab the next Notification added to Atom, allowing situations such as waiting on the fix command.makeFixesfunction so it waits on the fix command to finish, including the file changes in Atom before continuing the spec.fixspecs use the same functions so the code isn't duplicated.lintfunction directly, using the worker spawned from theactivatecall instead of a separate one spawned in the specs.