This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Utilize warnIgnored instead of filtering messages #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that all execution of ESLint is being done through `executeOnText` we can move to the `warnIgnored` option instead of manually filtering out the ignore messages. Fixes #900.
|
Turns out this was entirely wrong. The option has no meaning there and needed to be passed in as a third argument to The reason we never saw that this wasn't working is that the default behavior was fixed to be what you would expect anyway in eslint/eslint#6632. |
Arcanemagus
added a commit
that referenced
this pull request
Jan 7, 2018
This flag has no meaning to the `CLIEngine` constructor, it is only valid as an optional third argument to `executeOnText`. When this was mistakenly added in #915 this was missed. Luckily the problem it was meant to solve was accepted as a bug against ESLint itself and fixed there which is why this wasn't caught earlier.
Arcanemagus
added a commit
that referenced
this pull request
Jan 15, 2018
This flag has no meaning to the `CLIEngine` constructor, it is only valid as an optional third argument to `executeOnText`. When this was mistakenly added in #915 this was missed. Luckily the problem it was meant to solve was accepted as a bug against ESLint itself and fixed there which is why this wasn't caught earlier.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all execution of ESLint is being done through
executeOnTextwe can move to thewarnIgnoredoption instead of manually filtering out the ignore messages.Fixes #900.