This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Force atom-babel6-transpiler to not set BABEL_ENV #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although we aren't utilizing it, `atom-babel6-transpiler` was setting `BABEL_ENV` to `undefined` whenever this package was transpiled leading to other Atom packages that use that environment variable to become corrupted.
IanVS
approved these changes
Jul 22, 2017
There was a problem hiding this comment.
Nice! This would have saved me a bunch of time today in fact, troubleshooting why eslint-plugin-import was failing, specifically eslint-import-resolver-babel-modules was crashing without a stack trace, and it turned out it was an error being thrown from babel-preset-react-app due to the undefined BABEL_ENV.
Hopefully this saves other users some headaches.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we aren't utilizing
BABEL_ENV,atom-babel6-transpilerwas settingBABEL_ENVtoundefinedwhenever this package was transpiled leading to other Atom packages that use that environment variable to become corrupted.Fixes #921.