This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Add an ESLint Fix right click command #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IanVS Do we want to take on this "black magic", or is there a better way? |
IanVS
approved these changes
Jul 22, 2017
There was a problem hiding this comment.
I'm not too concerned about the "black magic". I see this as a minor nice-to-have feature, and if it breaks at some point in the future we can either fix it at that point, or drop it. No sense stressing about the private methods right now, in my mind. If it works (which it seems to), then 
src/main.js
Outdated
| // Compares the private component property of the active TextEditor | ||
| // against the components of the elements | ||
| const evtIsActiveEditor = evt.path.some(elem => | ||
| elem.component && elem.component === activeEditor.component) |
There was a problem hiding this comment.
Note: it seems that activeEditor does not have a component prop in atom 1.18.0, so this only works in 1.19.0 and up. I think that's fine, personally.
There was a problem hiding this comment.
Fixed for Atom v1.18.0 😉.
Arcanemagus
force-pushed
the
arcanemagus/fix-right-click
branch
from
8ee4be5 to
dd3e260
Compare
Add an "ESLint Fix" command to the right click menu when it is the active editor and is listed as a valid scope according to the current settings.
Arcanemagus
force-pushed
the
arcanemagus/fix-right-click
branch
from
dd3e260 to
95bad33
Compare
|
Awesome, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an "ESLint Fix" command to the right click menu when it is the active editor and is listed as a valid scope according to the current settings.
Fixes #955.