-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
Thank you for your work, looks great. |
@@ -3,7 +3,11 @@ module.exports = | |||
executablePath: | |||
type: 'string' | |||
default: 'rustc' | |||
description: 'Path to rust compiller.' | |||
description: 'Path to rust compiler' | |||
executablePath2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should use more understandable names of config variables, e.g. rustcPath
and cargoPath
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmist executablePath
is used by upstream Linter. If i remove executablePath
(and add rustcPath, cargoPath as you suggested) here, Linter will always add another executablePath
in settings page, which looks weird. Maybe I'm wrong.
@dgriffen Fixed. Thank you! |
Any updates on this? |
@frewsxcv Blocked on steelbrain/linter#304. |
Closing, 34ae462 was committed, already works for cargo. |
Does it work for anybody on Windows? I'm using Cargo and currently getting an Edit: Nevermind, I forgot to type the |
This PR add the support of Cargo to Rust Linter. We try to find file
Cargo.toml
first, to decide which we should use it to lint the source file,cargo
(if we found aCargo.toml
) orrustc
(if not found). Both rustc and cargo's path are configurable.We also need to improve Linter repo to complete this work. Currently, blocked by steelbrain/linter#290 and steelbrain/linter#304. These two PRs of mine are under reviewing.
Closes #4
update:
one limitation: when lint using cargo, you must save the editing file first. it is too expensive to copy the full cargo package to tmp directory, imo.