feat: get inputs for dual funding #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 82ed846 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewjablack
force-pushed
the
get-inputs-for-dual-funding
branch
from
e940fab
to
82ed846
Compare
Pull Request Test Coverage Report for Build 8286485376Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improve utxo selection process for DLC creation
Specifically add
getInputsForDualFundingwhich accounts for DLC offer/accept fees using AtomicFinance/node-dlc#206dualFundingCoinSelectwhich calculates DLC funding and execution fees an accounts for this in input selection.Why
Since it's a dual funded transaction, each user pays for half of the base tx fees, and their share of the inputs they provide, which ends up being less than a typical transaction.
This fixes edge cases where there might not be enough inputs in a typical scenario for a single funded transaction, but there in fact is enough for a dual funded one.