Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 The ovrlays stop working once a drag-drop is not completed successfully #536

Closed
1 task done
cruxcode opened this issue Nov 9, 2022 · 1 comment · Fixed by #537
Closed
1 task done

🐞 The ovrlays stop working once a drag-drop is not completed successfully #536

cruxcode opened this issue Nov 9, 2022 · 1 comment · Fixed by #537
Labels
bug Something isn't working

Comments

@cruxcode
Copy link
Collaborator

cruxcode commented Nov 9, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When we drag a component and drop it outside the canvas i.e. resulting in a failed drag-drop operation, the overlays stop working after that.

Error message

No response

Screenshots

No response

Expected Behavior

The overlays should keep on working.

System configuration

No response

Steps To Reproduce

1. Drag a component.
2. Drop it outside canvas.

Anything else?

No response
@cruxcode cruxcode added the bug Something isn't working label Nov 9, 2022
@cruxcode
Copy link
Collaborator Author

cruxcode commented Nov 9, 2022

We need call cancelMachineLock when drag fails.

cruxcode added a commit to cruxcode/atrilabs-engine that referenced this issue Nov 9, 2022
@cruxcode
fixes Atri-Labs#504 fixes Atri-Labs#536
980f07c
@cruxcode cruxcode mentioned this issue Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix state machines related issues cruxcode/atrilabs-engine
1 participant
@cruxcode