Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor custom props #623

Merged
merged 31 commits into from
Jan 5, 2023
Merged

Refactor custom props #623

merged 31 commits into from
Jan 5, 2023

Conversation

jonathanalvares9009
Copy link
Collaborator

Reference

Add reference to a related issue that this pull request is addressing. For example, fixes #603

Describe the pull request

This PR implements array_map in step, accordion, dropdown and carousel and implements array_typed_map in form

Please describe the changes proposed in this pull request.

Contributors (in case of a commit with multiple authors)

Co-authors:

@jonathanalvares9009
Wired in the refactored custom prop
dd4254c
@jonathanalvares9009
Connected the new custom props and DevStep component
738c88e
@jonathanalvares9009
Connected refactored custom props with Step component
31e42fe
@jonathanalvares9009
Removed the old custom props
ac89d2a
@jonathanalvares9009
Connected refactored props in dropdown
c962405
@jonathanalvares9009
Connected the refactored custom props and dropdown
3a0263d
@jonathanalvares9009
Removed the old custom props
c89cd11
@jonathanalvares9009
Wired up the refactored custom props and removed the old ones
bbb33b2
@jonathanalvares9009
Connect the refactored custom props and the carousel component
75fd450
@jonathanalvares9009
Defined refactored custom props for Accordian
97bc2eb
@jonathanalvares9009
Removed the old custom props and connected the refactored custom prop…
c4fb27c 
…s to Accordion components
@jonathanalvares9009
Added alert to manifest
e2e0572
@jonathanalvares9009
Defined target custom prop and used it
45fc63c
@jonathanalvares9009
Implemented autocomplete in form component
556f4ea
@jonathanalvares9009
Defined attributes for text, password, radio and select
43fbe34
@jonathanalvares9009
Implemented custom props for checkbox, color and date
2c4e6d2
@jonathanalvares9009
Implemented custom props for time, datetime-local, url, search and email
8645022
@jonathanalvares9009
Implemented image and file custom props
afa2464
@jonathanalvares9009
Datatype for form attributes
6f74f31
@jonathanalvares9009
Defined datatype for radio, checkbox, time, file and image
b75ae46
@jonathanalvares9009
Provided initial value to form component
96ce41b
@jonathanalvares9009
Commented the code out
d0d351e
@jonathanalvares9009
Implemented type checking for selectedOption and removed commented code
a1fe639
@jonathanalvares9009
Implemented select attribute in form
01444ad
@jonathanalvares9009
Removed image type from form
7afe515
@jonathanalvares9009
Implemented multiple attribute select
2b489fb
@jonathanalvares9009
Implemented file in form
9cfb098
@jonathanalvares9009
Implemented checkbox in form
940b9ba
@jonathanalvares9009
Implemented other attributes in a form
e5f1b94
@cruxcode cruxcode merged commit 707f1e0 into Atri-Labs:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cruxcode cruxcode Awaiting requested review from cruxcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor components to use array_map
2 participants
@jonathanalvares9009 @cruxcode